stable

Clone or download

Read-only

request #14727: Properties, parameters and return types of methods/functions should always be defined

Partially automated with `php ../../src/vendor/bin/psalm -c=tests/psalm/psalm.xml --alter --issues=MissingReturnType,MissingParamType` Change-Id: I9c618d1269d2b21ebb5c30086419a77146ffb2ee

Modified Files

Name
M include/RealTime/RealTimeMessageSender.php +15 −15 Go to diff View file
M include/TestManagement/AdminController.class.php +35 −20 Go to diff View file
M include/TestManagement/AdminPresenter.class.php +6 −6 Go to diff View file
M include/TestManagement/Administration/StepFieldUsageDetector.php +2 −2 Go to diff View file
M include/TestManagement/ArtifactDao.php +50 −14 Go to diff View file
M include/TestManagement/ArtifactFactory.php +2 −2 Go to diff View file
M include/TestManagement/Breadcrumbs/AdmininistrationBreadcrumbs.php +1 −1 Go to diff View file
M include/TestManagement/Breadcrumbs/Breadcrumbs.php +1 −1 Go to diff View file
M include/TestManagement/Breadcrumbs/NoCrumb.php +1 −1 Go to diff View file
M include/TestManagement/Campaign/AutomatedTests/AutomatedTestsTriggerer.php +2 −2 Go to diff View file
M include/TestManagement/Campaign/Campaign.php +3 −2 Go to diff View file
M include/TestManagement/Campaign/CampaignDao.php +4 −4 Go to diff View file
M include/TestManagement/Campaign/CampaignRetriever.php +3 −2 Go to diff View file
M include/TestManagement/Campaign/CampaignSaver.php +2 −2 Go to diff View file
M include/TestManagement/Campaign/Execution/DefinitionNotFoundException.php +3 −0 Go to diff View file
M include/TestManagement/Campaign/Execution/ExecutionDao.php +5 −5 Go to diff View file
M include/TestManagement/Campaign/JobConfiguration.php +1 −1 Go to diff View file
M include/TestManagement/Config.class.php +13 −7 Go to diff View file
M include/TestManagement/Criterion/ISearchOnMilestone.php +1 −1 Go to diff View file
M include/TestManagement/Criterion/ISearchOnStatus.php +4 −4 Go to diff View file
M include/TestManagement/Criterion/MilestoneAll.php +1 −2 Go to diff View file
M include/TestManagement/Criterion/MilestoneFilter.php +2 −3 Go to diff View file
M include/TestManagement/Criterion/StatusAll.php +4 −4 Go to diff View file
M include/TestManagement/Criterion/StatusClosed.php +4 −4 Go to diff View file
M include/TestManagement/Criterion/StatusOpen.php +4 −4 Go to diff View file
M include/TestManagement/Dao.class.php +15 −11 Go to diff View file
M include/TestManagement/Event/GetItemsFromMilestone.php +5 −5 Go to diff View file
M include/TestManagement/Event/GetMilestone.php +5 −5 Go to diff View file
M include/TestManagement/FirstConfigCreator.class.php +15 −9 Go to diff View file
M include/TestManagement/IndexController.class.php +7 −2 Go to diff View file
M include/TestManagement/IndexPresenter.class.php +10 −4 Go to diff View file
M include/TestManagement/MalformedQueryParameterException.php +1 −1 Go to diff View file
M include/TestManagement/Nature/NatureCoveredByOverrider.php +1 −1 Go to diff View file
M include/TestManagement/REST/MilestoneItemsArtifactFactory.php +4 −4 Go to diff View file
M include/TestManagement/REST/ResourcesInjector.class.php +2 −2 Go to diff View file
M include/TestManagement/REST/v1/ArtifactNodeBuilder.php +22 −7 Go to diff View file
M include/TestManagement/REST/v1/ArtifactNodeDao.php +17 −2 Go to diff View file
M include/TestManagement/REST/v1/AssignedToRepresentationBuilder.php +3 −0 Go to diff View file
M include/TestManagement/REST/v1/BugRepresentation.php +1 −1 Go to diff View file
M include/TestManagement/REST/v1/CampaignCreator.class.php +22 −12 Go to diff View file
M include/TestManagement/REST/v1/CampaignRepresentation.class.php +10 −4 Go to diff View file
M include/TestManagement/REST/v1/CampaignRepresentationBuilder.php +6 −5 Go to diff View file
M include/TestManagement/REST/v1/CampaignUpdater.class.php +8 −3 Go to diff View file
M include/TestManagement/REST/v1/CampaignsResource.class.php +17 −11 Go to diff View file
M include/TestManagement/REST/v1/DefinitionRepresentation.php +3 −0 Go to diff View file
M include/TestManagement/REST/v1/DefinitionRepresentationBuilder.php +2 −2 Go to diff View file
M include/TestManagement/REST/v1/DefinitionSelector.php +16 −6 Go to diff View file
M include/TestManagement/REST/v1/DefinitionsResource.class.php +7 −2 Go to diff View file
M include/TestManagement/REST/v1/ExecutionCreator.class.php +17 −8 Go to diff View file
M include/TestManagement/REST/v1/ExecutionRepresentation.php +11 −11 Go to diff View file
M include/TestManagement/REST/v1/ExecutionRepresentationBuilder.php +14 −12 Go to diff View file
M include/TestManagement/REST/v1/ExecutionStatusUpdater.php +2 −1 Go to diff View file
M include/TestManagement/REST/v1/ExecutionsResource.class.php +51 −35 Go to diff View file
M include/TestManagement/REST/v1/JobConfigurationRepresentation.php +1 −1 Go to diff View file
M include/TestManagement/REST/v1/MinimalDefinitionRepresentation.php +5 −2 Go to diff View file
M include/TestManagement/REST/v1/NodeBuilderFactory.php +1 −1 Go to diff View file
M include/TestManagement/REST/v1/NodeReferenceRepresentation.php +30 −9 Go to diff View file
M include/TestManagement/REST/v1/NodeRepresentation.php +6 −1 Go to diff View file
M include/TestManagement/REST/v1/NodesResource.class.php +5 −3 Go to diff View file
M include/TestManagement/REST/v1/PaginatedCampaignsRepresentations.php +3 −3 Go to diff View file
M include/TestManagement/REST/v1/PreviousResultRepresentation.php +5 −5 Go to diff View file
M include/TestManagement/REST/v1/ProjectResource.class.php +16 −10 Go to diff View file
M include/TestManagement/REST/v1/SlicedExecutionRepresentations.php +1 −1 Go to diff View file
M include/TestManagement/REST/v1/StepDefinitionRepresentation.php +2 −2 Go to diff View file
M include/TestManagement/REST/v1/StepResultRepresentation.php +1 −1 Go to diff View file
M include/TestManagement/REST/v1/StepsResultsChangesBuilder.php +7 −5 Go to diff View file
M include/TestManagement/REST/v1/TestStatusAccordingToStepsStatusChangesBuilder.php +9 −3 Go to diff View file
M include/TestManagement/Router.class.php +12 −8 Go to diff View file
M include/TestManagement/StartTestManagementController.php +6 −6 Go to diff View file
M include/TestManagement/StartTestManagementPresenter.php +16 −6 Go to diff View file
M include/TestManagement/Step/Definition/Field/StepDefinition.php +68 −30 Go to diff View file
M include/TestManagement/Step/Definition/Field/StepDefinitionChangesetValue.php +4 −0 Go to diff View file
M include/TestManagement/Step/Definition/Field/StepDefinitionChangesetValueDao.php +9 −3 Go to diff View file
M include/TestManagement/Step/Execution/Field/StepExecution.php +25 −1 Go to diff View file
M include/TestManagement/Step/Execution/Field/StepExecutionChangesetValue.php +4 −0 Go to diff View file
M include/TestManagement/Step/Execution/Field/StepExecutionChangesetValueDao.php +8 −3 Go to diff View file
M include/TestManagement/Step/Execution/StepResult.php +1 −1 Go to diff View file
M include/TestManagement/Step/Execution/StepResultPresenter.php +3 −0 Go to diff View file
M include/TestManagement/Step/Step.php +8 −8 Go to diff View file
M include/TestManagement/Step/StepPresenter.php +27 −3 Go to diff View file
M include/TestManagement/TestManagementController.php +5 −1 Go to diff View file
M include/TestManagement/TestManagementPluginDescriptor.class.php +1 −1 Go to diff View file
M include/TestManagement/TestManagementPluginInfo.class.php +1 −1 Go to diff View file
M include/TestManagement/TrackerComesFromLegacyEngineException.php +1 −1 Go to diff View file
M include/TestManagement/XML/Exporter.php +2 −1 Go to diff View file
M include/TestManagement/XML/ImportXMLFromTracker.php +1 −1 Go to diff View file
M include/TestManagement/XML/TrackerXMLExporterChangesetValueStepDefinitionXMLExporter.php +1 −1 Go to diff View file
M include/TestManagement/XML/XMLImport.php +6 −3 Go to diff View file
M include/testmanagementPlugin.php +44 −36 Go to diff View file
M tests/psalm/psalm.xml +0 −8 Go to diff View file