Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto: put cross tracker report permission checks in dedicated class

Download Browse

Part of story #38263 Choose my own columns based on field name (numeric, text, dates) The resource class is only the entry point, it is not its responsability to check the cross tracker report permission and should be in a dedicated class. Moving this part make this part also more testable. No functional change expected Change-Id: I43c18b8f256d07bfa21b0c69c192ec8aafb4ae69

+333 −52
Clarck Robinson (robinsoc) 2024-06-03 18:12
Clarck Robinson (robinsoc) 2024-06-03 18:18
abde99d4bbe264fcc2f56ed7649136dc74b632ac
11da3d4eb048a30738b52c219092ad44357bd7b8
git #tuleap/stable/abde99d4bbe264fcc2f56ed7649136dc74b632ac

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/CrossTrackerReportDao.php +1 −1 Go to diff View file
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +24 −50 Go to diff View file
A plugins/crosstracker/include/CrossTracker/REST/v1/UserIsAllowedToSeeReportChecker.php +66 −0 Go to diff View file
A plugins/crosstracker/include/CrossTracker/SearchCrossTrackerWidget.php +31 −0 Go to diff View file
A plugins/crosstracker/tests/unit/CrossTracker/REST/v1/UserIsAllowedToSeeReportCheckerTest.php +156 −0 Go to diff View file
A plugins/crosstracker/tests/unit/CrossTracker/SearchCrossTrackerWidgetStub.php +39 −0 Go to diff View file
M src/common/REST/ProjectAuthorization.php +2 −1 Go to diff View file
M src/common/include/CheckUserCanAccessProject.php +14 −0 Go to diff View file