Closes request #37944 Flaky TV3 migration tests No functional change. $ make tests-db SEED=1715767234 The command above should pass, same for SEED=1715777716 Why? - Those tests are flaky because they start by a beforeClass method that migrates a TV3 tracker to TV5, and then search again the tracker by its ID. Other tests might be played in-between and might change data, so there is actually no guarantee that the numeric ID will be found again. Instead of doing this, we flatten everything to a single integration test. It was always a single scenario: we migrate the tracker, and then run some assertions on it, this does not change. By doing it in a single test, there are no more interferences from other tests. It also paves the way to running it in a rolled-back transaction, something that cannot be done yet (something in the code commits the transaction). - in PHPUnit assertions, the expectation always comes first in the parameters. I took the opportunity to also add return types, to use stricter assertions and to use self instead of $this for assertion methods. Change-Id: I569a4c33b22061c4cce9cc0d04868502ef9fc62d

+362 −285

Author

Joris MASSON (jmasson) 2024-05-15 16:25

Committer

Joris MASSON (jmasson) 2024-05-15 17:47

Hash ac5e238c74c6c8ebb31fa99bd857b15082f8ce6d

Parent 530f5ba7143a05d54d8d4277951a1882b373d8be

Reference git #tuleap/stable/ac5e238c74c6c8ebb31fa99bd857b15082f8ce6d