stable

Clone or download

Read-only

feat: error state for subtasks

If the retrieval of subtasks fails, then an error message is displayed. For now the message is generic, we will see in the wild if we need to give more details to the end user. Implementation note 1: Using directly the tlp-alert component brings too much overriding, therefore we now expose the component colors so that we have better control of the message display inside the gantt chart. Implementation note 2: Due to the way the gantt board is built (scrolling areas, header fixed, …), the dom element containing the message is written outside its logical container. The latter takes the necessary space (task's height) while the former is positionned absolutely at the right position. Implementation note 2: The v-bind:key used for tasks has been changed to a more accurate key. The key should be linked to the element, not its position in the collection, else VueJS will be confused while diffing/rendering components when the collection is changed. This is highlighted here with popover that was targeting the wrong task bar. Part of story #20979: Display children in Roadmap Change-Id: I10f29e7e56409b8fbaf0bf20e0bb5ab44f05aa45

Modified Files

Name
M plugins/roadmap/scripts/roadmap-widget/po/fr_FR.po +3 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/GanttBoard.test.ts +64 −1 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/GanttBoard.vue +42 −6 Go to diff View file
A plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Subtask/SubtaskErrorHeader.vue +42 −0 Go to diff View file
A plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Subtask/SubtaskMessage.test.ts +43 −0 Go to diff View file
A plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Subtask/SubtaskMessage.vue +60 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/helpers/styles.ts +2 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-actions.test.ts +25 −3 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-actions.ts +18 −13 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-getters.test.ts +32 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-getters.ts +7 −1 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-mutations.test.ts +17 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-mutations.ts +13 −1 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/type.ts +8 −2 Go to diff View file
M plugins/roadmap/themes/_gantt-board.scss +1 −0 Go to diff View file
M plugins/roadmap/themes/_gantt-header.scss +21 −2 Go to diff View file
M plugins/roadmap/themes/_roadmap-variables.scss +3 −1 Go to diff View file
M src/themes/tlp/src/scss/components/_alerts.scss +3 −3 Go to diff View file
M src/themes/tlp/src/scss/components/_css-var-root.scss +5 −0 Go to diff View file