part of request #25696 Workflow can be broken due to deleted values in transition Rest route returns every transition it found, even when they can not be applied Given a list value have been deleted and given workflow had a transition on it, then the rest route can returns incorrect transitions (from null or to null) Rest route should not provide inconsistent data Note: I don't think I have the best way to reproduce issue: Have a tracker without workflow: - in a tab open the status field and edit it to see its values - in an other tab set a workflow on status, define transitions on the value you want to delete (from and to) - once the workflow is set, remove the value in first tab - go back in workflow and refresh - check the rest routes: when we retrieve the workflow we can see in its representation that there are many transition with `from_id: null` or `to_id:null` This only fix rest api, `TransitionFactory` and `Transition` object still build broken data I'll handle them once by once to limit scope change It seems that there is a missing check on value suppression, the check of value usage seems not be checked by backend before the value removal, I'll handle separatly this issue Change-Id: If12838d89d97b406dc54f6401c9d8b11e7bef3c2

+313 −123

Author

Marie Ange Garnier (marieange) 2022-03-10 11:00

Committer

Marie Ange Garnier (marieange) 2022-03-15 17:13

Hash ad848c1fa837e762881d39f960fef0206a4d900b

Parent 75f9f8b79d24ed158a479c2c30c76833148f0f0d

Reference git #tuleap/stable/ad848c1fa837e762881d39f960fef0206a4d900b