Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: DynamicCredentials (non) session storage

Download Browse

This is a follow-up commit of 4da4a83de0fc48d4bd12168f7cdab61b3f80e60f The original fix completly discarded Dynamic Credential usage in the context without session (SVNAuthController ATM) but it was not perfect. This patch uses a regular array for storage (instead of session) when session are not allowed to persist "session" information. The array is static to be persisted across the request (a Singleton might have been a more explicit solution but was less convenient to implement). Part of request #30024 DynamicCredentials prevent svn caching mecanism to work Change-Id: I35073cd3f1bf5770d61fbc4733c41ff20e43d8f6

+18 −13
Manuel Vacelet (vaceletm) 2023-01-05 15:16
Manuel Vacelet (vaceletm) 2023-01-06 10:36
afa9b0344bd764dee0a610f85c11e232826d75db
2ee4c6373d7288eb13cd99ec653137d3804eb9d4
git #tuleap/stable/afa9b0344bd764dee0a610f85c11e232826d75db

Modified Files

Side by side diff
Inline diff
Name
M plugins/dynamic_credentials/include/dynamic_credentialsPlugin.php +18 −13 Go to diff View file