stable

Clone or download

Read-only

Refactoring of svn PreCommit hook

As we are about to introduce another check on files about to be commited, let's start by refactor how the current check are done for tags and sha1 collision detector. Each had their own loop on files, that was not really efficient and there were already two ways to iterate on it. Everything should work as before. Part of story #19285 limit the max size of files in svn Change-Id: Id16d1628e384ca10509c967614fbd412d567ff84

Modified Files

Name
M plugins/svn/bin/svn_pre_commit.php +21 −21 Go to diff View file
M plugins/svn/include/Events/SystemEvent_SVN_RESTORE_REPOSITORY.php +2 −4 Go to diff View file
M plugins/svn/include/SVN/Admin/ImmutableTag.php +5 −0 Go to diff View file
M plugins/svn/include/SVN/Admin/ImmutableTagFactory.php +6 −25 Go to diff View file
M plugins/svn/include/SVN/Commit/CommitMessageValidator.php +13 −7 Go to diff View file
A plugins/svn/include/SVN/Commit/CommitMessageWithoutReferenceException.php +32 −0 Go to diff View file
A plugins/svn/include/SVN/Commit/EmptyCommitMessageException.php +32 −0 Go to diff View file
M plugins/svn/include/SVN/Commit/Svnlook.php +8 −0 Go to diff View file
M plugins/svn/include/SVN/Hooks/PreCommit.php +57 −77 Go to diff View file
M plugins/svn/include/SVN/Repository/RepositoryManager.php +3 −3 Go to diff View file
M plugins/svn/tests/unit/SVN/Hooks/PreCommitSHA1CollisionTest.php +14 −17 Go to diff View file
M plugins/svn/tests/unit/SVN/Hooks/PreCommitTest.php +40 −33 Go to diff View file
M plugins/svn/tests/unit/SVN/Repository/RepositoryManagerTest.php +2 −2 Go to diff View file