Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Open modal to create an activity in a kanban

Download Browse

…instead of leaving the current page and losing the context. Given a kanban is based on a tracker (e.g Activity) that is promoted in the «+ New» dropdown, When user goes to the given kanban And select the "Add new Activity" in the "+ New» dropdown, Then the modal to create the activity is displayed just like if the user would have clicked on the primary button "Add new Activity" above the kanban. Note: in the rare case where the tracker is not configured enough to have the primary button "Add new activity" (e.g lack of semantic), then the old behavior is kept (redirection to the tracker service with a possible loss of context). The criticity of this case is considered low enough to not have to handle it right now. Part of story #16206: « + New » button, better contextualisation Change-Id: I5e165907578578a4c677ee50352c52f02e9516c1

+186 −35
Nicolas Terray (nterray) 2020-11-17 18:53
Nicolas Terray (nterray) 2020-11-17 18:53
b037359faf6f64a6c93adf4f72abfadc8860bc32
7e77e4331fba23ee3525f9750cd2282a1f153916
git #tuleap/stable/b037359faf6f64a6c93adf4f72abfadc8860bc32

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/scripts/kanban/src/app/app-kanban-controller.js +6 −0 Go to diff View file
M plugins/tracker/include/Tracker/NewDropdown/TrackerLinksInNewDropdownCollector.php +11 −13 Go to diff View file
A plugins/tracker/include/Tracker/NewDropdown/TrackerNewDropdownLinkPresenterBuilder.php +41 −0 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +3 −8 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +3 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/NewDropdown/TrackerLinksInNewDropdownCollectorTest.php +7 −3 Go to diff View file
A plugins/tracker/tests/unit/Tracker/NewDropdown/TrackerNewDropdownLinkPresenterBuilderTest.php +53 −0 Go to diff View file
A src/common/layout/NewDropdown/DataAttributePresenter.php +44 −0 Go to diff View file
M src/common/layout/NewDropdown/NewDropdownLinkPresenter.php +12 −4 Go to diff View file
M src/common/layout/NewDropdown/NewDropdownPresenterBuilder.php +1 −1 Go to diff View file
M src/themes/BurningParrot/templates/navbar/new-nav.mustache +1 −1 Go to diff View file
M tests/unit/common/layout/NewDropdown/NewDropdownPresenterBuilderTest.php +4 −4 Go to diff View file