Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Deduplicate retrieval of Tracker

Download Browse

part of request #23433 Clean program management tests No functional change expected. Given a TrackerIdentifier, we expect to always get a valid Tracker object, or else to throw an Exception. This behaviour was being repeated across several adapters. It's easier to reuse it with an interface (in the Adapters namespace). Adding a Stub lets us reduce the amout of mocking in our tests. Change-Id: If919cb1c47469b38faf2b192ab18ff166ce3f98f

+225 −200
Joris MASSON (jmasson) 2021-11-05 14:44
Joris MASSON (jmasson) 2021-11-05 17:20
b20ba73b327208e4858977efc1a1957c50565249
ef74ecc81e09aff5f78677e29641d89b43a26ae3
git #tuleap/stable/b20ba73b327208e4858977efc1a1957c50565249

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ArtifactCreatorAdapter.php +3 −7 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php +5 −3 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorBuilder.php +4 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php +4 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProjectFromTrackerRetriever.php +3 −7 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGatherer.php +8 −17 Go to diff View file
A plugins/program_management/include/Adapter/Workspace/Tracker/RetrieveFullTracker.php +34 −0 Go to diff View file
M plugins/program_management/include/Adapter/Workspace/Tracker/TrackerFactoryAdapter.php +12 −1 Go to diff View file
M plugins/program_management/include/Adapter/Workspace/Tracker/TrackerOfArtifactRetriever.php +4 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/RetrieveTitleField.php +1 −1 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +19 −19 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ArtifactCreatorAdapterTest.php +5 −22 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProjectFromTrackerRetrieverTest.php +20 −24 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGathererTest.php +2 −45 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Workspace/Tracker/TrackerFactoryAdapterTest.php +55 −23 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Workspace/Tracker/TrackerOfArtifactRetrieverTest.php +3 −24 Go to diff View file
A plugins/program_management/tests/unit/Stub/RetrieveFullTrackerStub.php +43 −0 Go to diff View file