stable
Clone or download
Read-only
Part of story #11661: define a merge strategy for my repositories IndexController should not have the responsibility to retrieve mirrors or permissions. Its current duty is to only display relevant pane. Retrieving mirrors or permissions is now delegated to dedicated Pane objects. This will help to introduce Pull requests pane. Took the time to add missing disabled panes. An issue introduced by this commit is the introduction of {{{ }}}. However, since there is no way to specify dynamically (by the presenter) which partial to load (because PR is a plugin and we cannot leak PR content in Git templates), then I do not see a better approach. Change-Id: I117a511ccf0ff5d774323070befff6e35722c7ba
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/include/Git.class.php | +4 | −3 | Go to diff View file |
| M | plugins/git/include/Git/DefaultSettings/IndexController.php | +58 | −109 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/AccessControl.php | +197 | −0 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/AccessControlPresenter.php | +251 | −0 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/DisabledPane.php | +37 | −0 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/Mirroring.php | +85 | −0 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/MirroringPresenter.php | +54 | −0 | Go to diff View file |
| A | plugins/git/include/Git/DefaultSettings/Pane/Pane.php | +48 | −0 | Go to diff View file |
| M | plugins/git/include/Git/Permissions/TemplatePermissionsUpdater.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitPresenters/AdminDefaultSettingsPresenter.php | +5 | −329 | Go to diff View file |
| M | plugins/git/templates/admin-default-settings.mustache | +10 | −23 | Go to diff View file |