Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: CodeMirror keeps expanding itself indefinitely

Download Browse

Fixes request #35096 CodeMirror keeps expanding itself indefinitely How to reproduce: - Have a file containing bidirectional characters (alternatively you can remove the ng-if in file-diff.tpl.html line 22) - Commit it and create a pull-request - Go to the changes tab to review it --> The codemirror element keeps expanding indefinitely. How to test: --> The codemirror does not expand indefinitely anymore --> The codemirror is displayed full-height [Bonus] The "Binary file" and "Git-LFS file" previews are displayed full-height. To test it you can remove the ng-if directives l.30 & l.34 Change-Id: Ib6526c38225bb65bb8bbf5af0b27abb6ea2e7418

+30 −12
Thomas Gorka (tgorka) 2023-11-03 11:29
Thomas Gorka (tgorka) 2023-11-03 11:29
b43d52db579f9dcf482b2c78f5a934e5dbdb815c
addbf4259e16888bdfff8fd1b0afa2a8a07d2736
git #tuleap/stable/b43d52db579f9dcf482b2c78f5a934e5dbdb815c

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff.tpl.html +15 −11 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/themes/includes/_file-diff.scss +15 −1 Go to diff View file