Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #12529: Git clone protocol should be HTTPS for anonymous

Download Browse

How to test: - Enable anonymous browsing on the platform - Give Anonymous Read access to a Git repository - Given my platform allows HTTPS ($git_http_url is not empty in git/etc/config.inc), when I browse a repository as anonymous, I should see HTTPS URL selected by default - When the platform does not allow HTTPS and I browse as anonymous, I won't see the clone bar. Change-Id: I635d47b85417d525dab6c3e6128dd2e180ad517f

+398 −123
Joris MASSON (jmasson) 2018-11-15 15:07
Joris MASSON (jmasson) 2019-02-04 15:35
b4af3f18d4e30d121f77f09ee6eff1f782f2d5e7
0868d2ba0c1693287f7cf5fe9b53638faff3ed1d
git #tuleap/stable/b4af3f18d4e30d121f77f09ee6eff1f782f2d5e7

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git/Repository/GitRepositoryHeaderDisplayerBuilder.php +4 −2 Go to diff View file
M plugins/git/include/Git/Repository/View/ClonePresenter.php +61 −65 Go to diff View file
A plugins/git/include/Git/Repository/View/DefaultCloneURL.php +52 −0 Go to diff View file
A plugins/git/include/Git/Repository/View/DefaultCloneURLSelector.php +65 −0 Go to diff View file
A plugins/git/include/Git/Repository/View/NoCloneURLException.php +25 −0 Go to diff View file
M plugins/git/include/Git/Repository/View/RepositoryHeaderPresenterBuilder.php +21 −13 Go to diff View file
A plugins/git/phpunit/Git/Repository/View/DefaultCloneURLSelectorTest.php +125 −0 Go to diff View file
M plugins/git/templates/repository/clone-bar.mustache +45 −43 Go to diff View file