stable

Clone or download

Read-only

fix deptrac issue on PermissionManager and DAO

part ot request #40476 Improve deptrac Both files are impacted by the same code design issue, they should be corrected together How to test: - make deptrac no longer raise error No functional changes on tracker duplication feature Change-Id: I81a3e0fb945136be2a1fb8aa423d1a4a56a1da47

Modified Files

Name
M plugins/tracker/include/Tracker/DateReminder/DateReminderDao.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Notifications/Settings/NotificationSettingsDuplicator.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Notifications/UgroupsToNotifyDuplicationDao.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/TrackerDuplicationUserGroupMapping.php +13 −44 Go to diff View file
M plugins/tracker/include/Tracker/TrackerFactory.class.php +11 −3 Go to diff View file
M plugins/tracker/include/Workflow/Transition/Condition/Permissions/Factory.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Workflow/Transition/ConditionFactory.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Workflow/TransitionFactory.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Workflow/WorkflowFactory.class.php +2 −2 Go to diff View file
M plugins/tracker/tests/integration/Notifications/Settings/NotificationSettingsDuplicatorTest.php +13 −13 Go to diff View file
A plugins/tracker/tests/unit/TrackerDuplicationUserGroupMappingTest.php +76 −0 Go to diff View file
M plugins/tracker/tests/unit/Workflow/Transition/Condition/Permissions/Workflow_Transition_Condition_Permissions_FactoryTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/unit/Workflow/Transition/Workflow_Transition_ConditionFactoryTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/unit/Workflow/TransitionFactoryTest.php +1 −1 Go to diff View file
R plugins/tracker/include/Tracker/TrackerDuplicationType.php Go to diff View file
A src/common/Project/Duplication/DuplicationUserGroupMapping.php +65 −0 Go to diff View file
M src/common/dao/PermissionsDao.class.php +4 −4 Go to diff View file
M src/common/permission/PermissionsManager.class.php +5 −5 Go to diff View file
M tests/unit/common/permission/PermissionsManagerTest.php +5 −5 Go to diff View file