Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Add DB transaction when deleting a project dashboard

Download Browse

Implements request #36841 Missing DB transaction when deleting a project dashboard No functional change expected when deleting a project dashboard. Why? If there is a problem while deleting a project dashboard, it should not leave leftover visits that will point to a non-existing dashboard. Everything should be deleted, or nothing. Change-Id: I4942090593ca6701ee47f38e236bc0444eb08477

+88 −60
Joris MASSON (jmasson) 2024-02-20 12:25
Joris MASSON (jmasson) 2024-02-20 12:25
b6462cc3ac853d590d49212c474e2d3d0f10f971
b45bf05f4437d616b72edcf03bbe8c8bea964bc4
git #tuleap/stable/b6462cc3ac853d590d49212c474e2d3d0f10f971

Modified Files

Side by side diff
Inline diff
Name
M src/common/Dashboard/Project/ProjectDashboardSaver.php +18 −8 Go to diff View file
M src/common/Project/Home.php +3 −0 Go to diff View file
M src/common/Project/ProjectXMLImporter.class.php +3 −0 Go to diff View file
M tests/unit/common/Dashboard/Project/ProjectDashboardSaverTest.php +62 −52 Go to diff View file
M tests/unit/common/Dashboard/Project/ProjectDashboardXMLImporterBase.php +2 −0 Go to diff View file