stable

Clone or download

Read-only

refactor: extract CheckPromotedTrackerConfiguration

For better SRP, the check of feature flag is moved in a dedicated object. This is necessary to be able to adapt the trackers promotion it trackers administration: tooltips and feedbacks should mention that promotion is for +New dropdown AND sidebar (this will be done in a dedicated changeset). No functional changes, the display of trackers in sidebar still depends on feature flag. tuleap config-set feature_flag_display_promoted_trackers_in_sidebar 0 tuleap config-set feature_flag_display_promoted_trackers_in_sidebar 1 Part of story #34002: see promoted trackers in sidebar Change-Id: Ief73e1f23b0ed3f9f32a6e095aec43fd8b865a20

Modified Files

Name
M plugins/tracker/include/ServiceTracker.class.php +2 −0 Go to diff View file
A plugins/tracker/include/Tracker/Service/CheckPromotedTrackerConfiguration.php +41 −0 Go to diff View file
A plugins/tracker/include/Tracker/Service/PromotedTrackerConfiguration.php +42 −0 Go to diff View file
A plugins/tracker/include/Tracker/Service/PromotedTrackerConfigurationChecker.php +26 −0 Go to diff View file
M plugins/tracker/include/Tracker/Service/SidebarPromotedTrackerRetriever.php +5 −33 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +2 −2 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Service/PromotedTrackerConfigurationCheckerStub.php +47 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Service/CheckPromotedTrackerConfigurationTest.php +85 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Service/SidebarPromotedTrackerRetrieverTest.php +13 −65 Go to diff View file