Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto: remove useless custom_hard_break

Download Browse

`custom_hard_break` has been introduced because we were thinking that original hard_break was defined with a toDOM `["br", 0]`. However this is not the case, the [`hard_break` definition][0] is exactly the same than our `custom_hard_break`. No need to keep twice the same implementation so lets delete our version. No functional changes, you can still introduce hard breaks in list items. Part of story #38627: Choice of a new Rich Text Editor [0]: https://github.com/ProseMirror/prosemirror-schema-basic/blob/master/src/schema-basic.ts#L97-L102 Change-Id: I9007d76adaa95dfc67abdc85ec02ffc1a9853d2c

+4 −18
Nicolas Terray (nterray) 2024-10-18 14:29
Nicolas Terray (nterray) 2024-10-18 14:29
b8666a32926b1d421085b19f6073b4d182882988
896645e275f40079aff51e96d4d54c21d3315533
git #tuleap/stable/b8666a32926b1d421085b19f6073b4d182882988

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/prose-mirror-editor/src/custom_schema.ts +1 −15 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/image/ImageFromSelectionExtractor.test.ts +1 −1 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/keymap.ts +1 −1 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/text-style/HeadingInSelectionRetriever.test.ts +1 −1 Go to diff View file