Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Reject comparison of submitter / last updater to empty string

Download Browse

part of story #10710 search on fields with duck typing Why? Queries like `submitted_by = ''` and `last_update_by = ''` are now rejected. Same thing for `IN('')`. Having an empty user name is forbidden, and artifacts always have a user that created them or updated them, even if it's a system user. Those queries cannot match any artifact, thus we should raise an error for them. Change-Id: I8a5e95e810d656bf92bef0fd847e4912aa8e4c03

+77 −19
Joris MASSON (jmasson) 2024-03-07 17:19
Joris MASSON (jmasson) 2024-03-07 17:36
b94fc483b97fe86d17f7e5df98305b6584e6640b
6dca900522fa9122945891a5b092de68e869630d
git #tuleap/stable/b94fc483b97fe86d17f7e5df98305b6584e6640b

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ArtifactSubmitterChecker.php +8 −11 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ArtifactSubmitterToEmptyStringException.php +37 −0 Go to diff View file
M plugins/tracker/site-content/fr_FR/LC_MESSAGES/tuleap-tracker.po +8 −0 Go to diff View file
M plugins/tracker/site-content/pt_BR/LC_MESSAGES/tuleap-tracker.po +6 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ArtifactSubmitterCheckerTest.php +11 −5 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +7 −3 Go to diff View file