Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: commonmark-popover won't open when WritingZone is toggled several times

Download Browse

part of story #32315 Add support of markdown How to reproduce: This behavior can be reproduced by toggling the reply form or the description edition form. 1. Either click on [Reply] to reply to an existing comment, or click [Edit] in the description's footer 2. Open the commonmark-popover 3. Close it 4. Click [Cancel] 5. Repeat steps 1 and 2 --> The popover won't open How to test: --> You can reopen the commonmark-popover when you toggle several times the forms. [Bonus] - Leave the popover open before canceling the comment - Toggle back the form --> The popover does not appear open anymore Change-Id: Ife8c24465f43ace7008673bd76e7cd8a8a705a23

+20 −7
Thomas Gorka (tgorka) 2023-09-07 11:56
Thomas Gorka (tgorka) 2023-09-07 17:00
b9f0f750e401eaa383d749f2be9fdffcee543f0b
f6f8f75fe3e9484dd63aa0fb959fc8380f1abd70
git #tuleap/stable/b9f0f750e401eaa383d749f2be9fdffcee543f0b

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/commonmark-popover/src/CommonmarkPopover.test.ts +6 −3 Go to diff View file
M lib/frontend/commonmark-popover/src/CommonmarkPopoverController.test.ts +6 −1 Go to diff View file
M lib/frontend/commonmark-popover/src/CommonmarkPopoverController.ts +8 −3 Go to diff View file