stable
Clone or download
Read-only
part of story #24969 [modal] add and remove links (replace current artifact link) How to test: When there is an error while retrieving the linked artifacts (either GET link types or GET linked_artifacts), an error message will be shown in the modal feedback (that is fixed and does not scroll) instead of the links field itself. You can test it by throwing a RestException in ArtifactsResource. When creating a new sub-item (for example a Task on a User Story), the modal feedback still shows its future parent. Notes: We should do the same for other fetch operations but it should come later. Change-Id: I68d511c7016063f5e84ce820ddc383c5deaa205d
Modified Files
Name | ||||
---|---|---|---|---|
A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.test.ts | +37 | −0 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.ts | +39 | −0 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.test.ts | +48 | −0 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.ts | +37 | −0 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedback.test.ts | +35 | −4 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedback.ts | +63 | −20 | Go to diff View file |
R | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedbackController.test.ts | Go to diff View file | ||
R | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedbackController.ts | Go to diff View file | ||
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkField.test.ts | +3 | −22 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkField.ts | +1 | −28 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldController.test.ts | +14 | −10 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldController.ts | +6 | −3 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldPresenter.test.ts | +2 | −16 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldPresenter.ts | +1 | −13 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkedArtifactTemplate.test.ts | +2 | −0 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/link-field-v2.scss | +0 | −4 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/src/domain/NotifyFault.ts | +24 | −0 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/LinkRetrievalFault.ts | +28 | −0 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/NoLinksInCreationModeFault.ts | +1 | −1 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js | +6 | −2 | Go to diff View file |
M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.tpl.html | +2 | −1 | Go to diff View file |
A | plugins/tracker/scripts/lib/artifact-modal/tests/stubs/NotifyFaultStub.ts | +36 | −0 | Go to diff View file |