stable

Clone or download

Read-only

Validate Date Fields Post actions

Part of story #12187 configure workflow pre & post actions at target state level How to test: - Using the REST API PUT /tracker_workflow_transitions/{id}/actions You should get a 400 Bad request when you try the following: - Submitting two "set_field_value" of type "date" with the same id - Submitting two "set_field_value" of type "date" with the same field_id - Submitting a "set_field_value" of type "date" with a field_id that does not match a "date" field that is used in the tracker. - There should not be any functional change for CI Build post actions Here's a sample body: { "post_actions": [{ "id": null, "type": "set_field_value", "field_id": 8196, "field_type": "date", "value": "" }, { "id": null, "type": "set_field_value", "field_id": 8196, "field_type": "date", "value": "current" }] } Change-Id: Ia91a0368135bdb62556ba4d14a16deb64653ccd9

Modified Files

Name
M plugins/tracker/include/REST/v1/Workflow/TransitionsResource.class.php +8 −19 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/Internal/CIBuildUpdater.php +2 −3 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/Internal/CIBuildValidator.php +20 −38 Go to diff View file
R plugins/tracker/include/workflow/PostAction/Update/Internal/InvalidCIBuildPostActionException.php Go to diff View file
R plugins/tracker/include/workflow/PostAction/Update/Internal/DuplicateCIBuildPostAction.php Go to diff View file
A plugins/tracker/include/workflow/PostAction/Update/Internal/PostActionIdValidator.php +63 −0 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/Internal/PostActionUpdater.php +1 −2 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/Internal/SetDateValueUpdater.php +11 −1 Go to diff View file
A plugins/tracker/include/workflow/PostAction/Update/Internal/SetDateValueValidator.php +110 −0 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/Internal/UnknownPostActionIdsException.php +6 −12 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/PostActionCollection.php +17 −3 Go to diff View file
M plugins/tracker/include/workflow/PostAction/Update/PostActionCollectionUpdater.php +2 −4 Go to diff View file
M plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/Internal/CIBuildUpdaterTest.php +3 −24 Go to diff View file
M plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/Internal/CIBuildValidatorTest.php +29 −35 Go to diff View file
A plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/Internal/PostActionIdValidatorTest.php +70 −0 Go to diff View file
M plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/Internal/SetDateValueUpdaterTest.php +37 −5 Go to diff View file
A plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/Internal/SetDateValueValidatorTest.php +126 −0 Go to diff View file
M plugins/tracker/phpunit/Tracker/Workflow/PostAction/Update/PostActionCollectionTest.php +0 −11 Go to diff View file
M plugins/tracker/site-content/fr_FR/LC_MESSAGES/tuleap-tracker.po +25 −5 Go to diff View file
M plugins/tracker/site-content/tuleap-tracker.pot +19 −4 Go to diff View file