Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Group Float field invalid checks together

Download Browse

part of story #10710 search on fields with duck typing No functional change. CI should be happy. Why? This is the beginning of the refactoring to transition away from invalid checks being grouped by comparison type (equals, lesser than, etc.). We want to group it by field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in a few files, instead of having all the business rules for "equals" comparison being grouped together. Change-Id: I1e0dc2706da16a3bd43bb4b0073470698355a0bd

+406 −204
Joris MASSON (jmasson) 2024-02-19 15:36
Joris MASSON (jmasson) 2024-02-20 10:20
bf154ce583c494211df7adb4d4d6b4c5d15aaeca
e81b8dfb4cb5a081bb3c2cb467ff98a92f370fbc
git #tuleap/stable/bf154ce583c494211df7adb4d4d6b4c5d15aaeca

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/BetweenComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/EqualComparisonVisitor.php +3 −1 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ExternalFieldNotSupportedException.php +36 −0 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FlatInvalidFieldChecker.php +191 −0 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FloatFields/FlatFloatFieldChecker.php +60 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FloatFields/FloatFieldChecker.php +6 −18 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanOrEqualComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/InComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanOrEqualComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotEqualComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotInComparisonVisitor.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidSearchableCollectorVisitor.php +30 −46 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php +37 −124 Go to diff View file
M plugins/tracker/site-content/fr_FR/LC_MESSAGES/tuleap-tracker.po +14 −7 Go to diff View file
M plugins/tracker/site-content/pt_BR/LC_MESSAGES/tuleap-tracker.po +5 −0 Go to diff View file
R plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidSearchablesCollectorVisitorTest.php Go to diff View file