Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: reduce nb of sql queries

Download Browse

Instead of querying three times the database to retrieve read, then write, then admin permission, we can do only one call. No functional changes. Part of story #25733: manage mediawiki permissions Change-Id: I5dea3d2ad51db19de55af0b6c15b8e2bd016afbb

+252 −453
Nicolas Terray (nterray) 2022-12-06 10:24
Nicolas Terray (nterray) 2022-12-06 11:43
c02a999eb43bb58a291c436081c704a35d750b87
b4b0038333b946cd79b332e4c0384f096f6443f6
git #tuleap/stable/c02a999eb43bb58a291c436081c704a35d750b87

Modified Files

Side by side diff
Inline diff
Name
D plugins/mediawiki_standalone/include/Permissions/AdminsRetriever.php +0 −44 Go to diff View file
R plugins/mediawiki_standalone/include/Permissions/ISearchByProjectAndPermission.php Go to diff View file
M plugins/mediawiki_standalone/include/Permissions/MediawikiPermissionsDao.php +6 −8 Go to diff View file
M plugins/mediawiki_standalone/include/Permissions/ProjectPermissionsRetriever.php +63 −8 Go to diff View file
D plugins/mediawiki_standalone/include/Permissions/ReadersRetriever.php +0 −42 Go to diff View file
D plugins/mediawiki_standalone/include/Permissions/WritersRetriever.php +0 −42 Go to diff View file
M plugins/mediawiki_standalone/include/REST/v1/MediawikiStandaloneProjectResource.php +1 −8 Go to diff View file
M plugins/mediawiki_standalone/include/mediawiki_standalonePlugin.php +29 −30 Go to diff View file
M plugins/mediawiki_standalone/tests/integration/Permissions/MediawikiPermissionsDaoTest.php +36 −52 Go to diff View file
M plugins/mediawiki_standalone/tests/unit/Permissions/Admin/AdminPermissionsControllerTest.php +7 −22 Go to diff View file
M plugins/mediawiki_standalone/tests/unit/Permissions/Admin/AdminPermissionsPresenterBuilderTest.php +3 −10 Go to diff View file
M plugins/mediawiki_standalone/tests/unit/Permissions/Admin/PermissionPerGroupServicePaneBuilderTest.php +3 −10 Go to diff View file
D plugins/mediawiki_standalone/tests/unit/Permissions/AdminsRetrieverTest.php +0 −45 Go to diff View file
R plugins/mediawiki_standalone/tests/unit/Permissions/ISearchByProjectAndPermissionStub.php Go to diff View file
A plugins/mediawiki_standalone/tests/unit/Permissions/ProjectPermissionsRetrieverTest.php +97 −0 Go to diff View file
D plugins/mediawiki_standalone/tests/unit/Permissions/ReadersRetrieverTest.php +0 −55 Go to diff View file
M plugins/mediawiki_standalone/tests/unit/Permissions/UserPermissionsBuilderTest.php +4 −12 Go to diff View file
D plugins/mediawiki_standalone/tests/unit/Permissions/WritersRetrieverTest.php +0 −55 Go to diff View file
M plugins/mediawiki_standalone/tests/unit/XML/XMLMediaWikiExporterTest.php +3 −10 Go to diff View file