stable
Clone or download
part of story #24197 search for Documents with criteria No functional changes: You should still be able to use docman legacy advanced search Why this change: In order to have REST route folder/id/search I'll need to build a Docman_Report (as explained in AC, I will build and object arround DocmanItem_DAO::searchId in order to don't break the existing code) In order to build my docman report I will need to build column report In his patch I only extract code from Docman_ReportFactory and unit test it in only remove the `if ($column !== null) ` because writing unit test show me that this case is not possible I keep previous code/formatting to ease review, I plan to rewrite code when I'll introduce the behviour of build the column report outside Codendi_Request Change-Id: Ic9850642adffab4d76840132095b415a02cbbbe8
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/docman/include/Docman_Report.class.php | +4 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_ReportColumn.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_ReportColumnFactory.class.php | +2 | −3 | Go to diff View file |
| M | plugins/docman/include/Docman_ReportColumnList.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_ReportColumnTitle.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_ReportFactory.class.php | +3 | −23 | Go to diff View file |
| A | plugins/docman/include/Search/ColumnReportAugmenter.php | +60 | −0 | Go to diff View file |
| A | plugins/docman/tests/unit/Search/ColumnReportAugmenterTest.php | +110 | −0 | Go to diff View file |