Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Make sure tests related CKEditor file upload handling test something

Download Browse

In 88b08fb2fa224a7838fab583f4f70244b07a0719, some fail() calls have been removed while doing the conversion from Jasmine to Jest. Those calls should not have been completely removed as it means that a test can now pass even if the code broken. Jest does not have a direct fail() equivalent to Jasmine's done.fail(), the idiomatic way to achieve that is to assert the number of expected assertions [0]. [0] https://jestjs.io/docs/en/asynchronous.html#async-await Part of request #13806: Use Jest as the default test framework for JS unit tests Change-Id: I4bc8ac94717dacf646ea3197d1f2141972eb7e45

+6 −0
Thomas Gerbet (tgerbet) 2019-09-05 10:37
Thomas Gerbet (tgerbet) 2019-09-05 10:37
c4cfa182d23d366a757cdd914b7c656d3bfece5b
5dd017b104200091f782bcccb0d129f56e84a06b
git #tuleap/stable/c4cfa182d23d366a757cdd914b7c656d3bfece5b

Modified Files

Side by side diff
Inline diff
Name
M src/www/scripts/tuleap/ckeditor/file-upload-handler-factory.test.js +6 −0 Go to diff View file