stable
Clone or download
Read-only
part of story #29228 Replace the current management of comments by a WebComponent in Overview and Changes view. What have been done: - The avatar are the arrow have been moved at the top left corner of the comment as shown on the mockup - Horizontal padding has been added on comments in the file-diff view - File-diff comments are now displayed full-width - I took the opportunity to extract the component's styles of the timeline's styles - I renamed every .pull-request-event* classes to .pull-request-comment* since the component is shared between two views. -- No functional change expected Change-Id: I1fb88123ca6f62f1b95b708046e6876b9fae897e
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.test.ts | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts | +7 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline.tpl.html | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/themes/includes/_file-diff.scss | +12 | −0 | Go to diff View file |
| M | plugins/pullrequest/themes/includes/_timeline.scss | +4 | −93 | Go to diff View file |
| A | plugins/pullrequest/themes/includes/_tuleap-pullrequest-comment.scss | +109 | −0 | Go to diff View file |
| M | plugins/pullrequest/themes/pull-requests.scss | +1 | −0 | Go to diff View file |