Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Have a better empty state message

Download Browse

part of story #35825 Pull request new home page - Filter on labels Currently, when all the pull-requests are closed, the empty state message says "No result match your query". This is a bit misleading since it can be displayed while no filters have been defined yet. The proposition is the following: - When some filters are defined -> display a "No matching results" message. - When the closed pull-requests are hidden -> display a "No open pull-requests" message Please note that the case "There are no open nor closed pull-requests" does not need to be implemented, since it already is. When no pull-requests exist in the reporitory, the backend serves a static page containing a dedicated empty state + the create pull-request button. How to test: - Go to a repository where there are only closed pull-requests --> Empty state says "no open pull-request" - Add some filters --> Empty state says "No matching results" Change-Id: Ie13f9f77bd14abd6e0ec2146aac705a686be0fb1

+115 −1
Thomas Gorka (tgorka) 2024-02-08 14:07
Thomas Gorka (tgorka) 2024-02-08 15:26
c63f7709caa180cf0c663fd3157cef3c1e9bd4c9
e9c5150f51eb532a69d9a35fb9dfc90dc5c70f08
git #tuleap/stable/c63f7709caa180cf0c663fd3157cef3c1e9bd4c9

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequest-homepage/po/fr_FR.po +6 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-homepage/src/components/List/PullRequestsList.vue +1 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequest-homepage/src/components/List/PullRequestsListEmptyState.test.ts +74 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-homepage/src/components/List/PullRequestsListEmptyState.vue +34 −1 Go to diff View file