Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto(artifact-links): Split getFieldDataFromRESTValue in several classes

Download Browse

part of story #24969 [modal] add and remove links without types No functional change expected: - Using the old field, I can still add a parent and add/remove the other links - Using the new field, I can still remove forward links Change-Id: I4455520fd56ab1dc12a80eed66695ab765e66d7a

+1582 −89
Thomas Gorka (tgorka) 2022-02-28 16:23
Thomas Gorka (tgorka) 2022-03-01 10:39
c6a47bd67bf0af9111db13e48445777848243bfc
501e2d3d69de00b057f06164abadda1519e63fd5
git #tuleap/stable/c6a47bd67bf0af9111db13e48445777848243bfc

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/FieldDataBuilder.php +0 −16 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactForwardLinksInfoRetriever.php +91 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLink.php +69 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksByChangesetCache.php +48 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksDiff.php +69 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValue.php +63 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilder.php +63 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueFormatter.php +60 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadExtractor.php +50 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadStructureChecker.php +56 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactParentLinkPayloadExtractor.php +41 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinks.php +65 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksInfo.php +51 −0 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/RetrieveForwardLinksInfo.php +33 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php +20 −20 Go to diff View file
M plugins/tracker/tests/unit/REST/FormElement/PermissionsForGroupsBuilderTest.php +2 −2 Go to diff View file
A plugins/tracker/tests/unit/Stub/RetrieveForwardLinksInfoStub.php +54 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/GetFieldDataTest.php +0 −26 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactForwardLinksInfoRetrieverTest.php +199 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinkTest.php +40 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksByChangesetCacheTest.php +46 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksDiffTest.php +69 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilderTest.php +105 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadExtractorTest.php +49 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadStructureCheckerTest.php +54 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactParentLinkPayloadExtractorTest.php +51 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksInfoTest.php +52 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksTest.php +64 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLinkTest.php +18 −25 Go to diff View file