Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Remove a fake empty time to display the table when it's empty

Download Browse

Part of request #35089 Convert personal-timetracking-widget to Vue3 + TS Motivation: When deleting the last time in the modal, an empty time (minute = null) was created to keep the modal display correct with the right artifact and project (because artifact and project were get with the first current time). In addition to an architectural problem, this forces us to make dates and times nullable when migrating to TypeScript. - Remove current_artifact and project_artifact getters - Pass the objects to the component's children No functional change expected, we can still add times after delete them all Change-Id: I4f275d6635f7f500e515c7e322a4e995295c0806

+45 −99
Clarisse Deschamps (cdeschamps) 2023-12-18 15:06
Clarisse Deschamps (cdeschamps) 2023-12-18 17:00
c8e1091c591e4723fab713b4c5653a139b049d46
bd530254d752ce1c0948328f5049798b18683a33
git #tuleap/stable/c8e1091c591e4723fab713b4c5653a139b049d46

Modified Files

Side by side diff
Inline diff
Name
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/WidgetArtifactTableRow.vue +5 −1 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalArtifactInfo.vue +8 −8 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalContent.vue +8 −4 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalEditTime.test.js +1 −18 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalEditTime.vue +2 −10 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalTable.test.js +1 −1 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalTable.vue +6 −1 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalTimes.test.js +3 −11 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalTimes.vue +9 −10 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/store/actions.test.js +1 −2 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/store/index.js +0 −26 Go to diff View file
M plugins/timetracking/scripts/personal-timetracking-widget/src/store/mutations.test.js +1 −7 Go to diff View file