Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Better UX when clearing reviewers

Download Browse

When you want to remove all reviewers, it was not clear that you have to submit the form with a empty field. Now, when you open the modal where there is at least one reviewer and you empty clear the field, the label button change and a message appears telling you the pull request won't have any reviewer. Part of story #14190: get email notifications on pull requests - first stage Change-Id: I379b9a4bfb053086561af1fa18e2b04007e26047

+93 −18
Benjamin Dauton (bdauton_enalean) 2019-11-25 18:53
Benjamin Dauton (bdauton_enalean) 2019-11-26 21:01
cab91d668bbbed23adbb9842c720bcbfca03525b
b2fb94b5e5b094ad769c509c6f97e77bf4ce4690
git #tuleap/stable/cab91d668bbbed23adbb9842c720bcbfca03525b

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/www/scripts/po/fr.po +14 −5 Go to diff View file
M plugins/pullrequest/www/scripts/src/app/overview/reviewers/update-reviewers-modal/update-reviewers-modal-controller.js +41 −1 Go to diff View file
M plugins/pullrequest/www/scripts/src/app/overview/reviewers/update-reviewers-modal/update-reviewers-modal.tpl.html +21 −9 Go to diff View file
M plugins/pullrequest/www/themes/BurningParrot/css/includes/_reviewers.scss +17 −3 Go to diff View file