Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Project admin must not crash if icon is unknown

Download Browse

part of story #22687 distinguish projects with an icon Why: Json decode can fail, we should ensure that when it fail it won't break every pages we display project icon. How to reproduce: On my instance, the motorcycle can't be rendered, it seems that I am the only one with this issue, you can simulate a wrong emoji by replacing $stored_emoji in EmojiCodepointConverter::convertStoredEmojiFormatToEmojiFormat with a random non emoji value Change-Id: I1ba34a438adcde9dc19d871196bd9f6770188bee

+10 −1
Marie Ange Garnier (marieange) 2021-10-22 15:24
Marie Ange Garnier (marieange) 2021-10-22 15:24
cae8d7781342d30d685eee0e43a8a03b671ed3e8
4b96eb9857dcec7ee1a536b3fc0666e6ae57bb50
git #tuleap/stable/cae8d7781342d30d685eee0e43a8a03b671ed3e8

Modified Files

Side by side diff
Inline diff
Name
M src/common/Project/Icons/EmojiCodepointConverter.php +5 −1 Go to diff View file
M tests/unit/common/Project/Icon/EmojiCodepointConverterTest.php +5 −0 Go to diff View file