stable

Clone or download

Read-only

chore(forge-config): Transfer dbauth user & password to database

The amount of things changed is, unfortunatly, high because of the very nature of those variables: - used heavily at the early stage of the application life (installation) - a password that should be stored encrypted but that wasn't Notes: - SetupMysqlInitCommand cannot re-use ConfigSet code to store the password because tuleap-cfg doesn't load pre.php so the database is not connected. So I had to write down the SQL queries directly. That's not ideal but I think the tradeof is acceptable at this point. - SetupMysqlInitCommand need a dirty workaround (ForgeConfig::set) because there is a dependency on it in KeyFactory. This step is mandatory to be able to auto generate local.inc. Part of: story #22708 flexibility in the management of Tuleap Configuration Change-Id: Iecac5f8199474a64ca23b9989be46c0314469f1d

Modified Files

Name
M plugins/ldap/tests/unit/LDAPBackendSVNTest.php +6 −0 Go to diff View file
M src/common/CLI/Command/ConfigGetCommand.php +7 −1 Go to diff View file
M src/common/CLI/Events/GetWhitelistedKeys.php +30 −10 Go to diff View file
M src/common/Config/ConfigKeyMetadata.php +1 −1 Go to diff View file
A src/common/Config/ConfigKeySecret.php +29 −0 Go to diff View file
M src/common/Config/ConfigKeyString.php +1 −1 Go to diff View file
M src/common/Config/ConfigSet.php +13 −14 Go to diff View file
M src/common/Config/ForgeConfig.php +38 −0 Go to diff View file
A src/common/Config/UnknownConfigKeyException.php +32 −0 Go to diff View file
A src/common/DB/DBAuthUserConfig.php +42 −0 Go to diff View file
M src/common/svn/SVN_Apache_ModPerl.class.php +3 −2 Go to diff View file
M src/db/mysql/database_structure.sql +1 −1 Go to diff View file
A src/db/mysql/updates/2022/202202091517_forgeconfig_value_as_text.php +37 −0 Go to diff View file
A src/db/mysql/updates/2022/202202101611_transfer_dbauthuser_and_password_to_forge_config.php +56 −0 Go to diff View file
M src/etc/local.inc.dist +0 −4 Go to diff View file
M src/tuleap-cfg/Command/SetupMysqlInitCommand.php +17 −36 Go to diff View file
M src/utils/tuleap.php +1 −1 Go to diff View file
M tests/e2e/full/tuleap/setup.sh +0 −1 Go to diff View file
M tests/integration/_fixtures/local.inc +0 −4 Go to diff View file
M tests/integration/bin/setup.sh +2 −2 Go to diff View file
M tests/integration/tests/Backend/BackendSVNTest.php +8 −1 Go to diff View file
M tests/rest/bin/setup.sh +0 −1 Go to diff View file
M tests/soap/bin/setup.sh +0 −1 Go to diff View file
M tests/unit/common/CLI/Events/GetWhitelistedKeysTest.php +17 −1 Go to diff View file
M tests/unit/common/Config/ForgeConfigTest.php +12 −0 Go to diff View file
M tests/unit/common/svn/SVN_Apache_ModPerlTest.php +10 −3 Go to diff View file
M tests/unit/common/svn/SVN_Apache_SvnrootConfTest.php +7 −1 Go to diff View file
M tests/unit/tuleap-cfg/Command/SetupMysqlInitCommandAzureTest.php +8 −7 Go to diff View file
M tests/unit/tuleap-cfg/Command/SetupMysqlInitCommandTest.php +6 −15 Go to diff View file
M tests/unit/tuleap-cfg/Command/TestDBWrapper.php +5 −3 Go to diff View file
M tools/setup/el7/include/core.sh +2 −2 Go to diff View file
M tools/setup/el7/include/plugins.sh +1 −1 Go to diff View file