Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Drop unnecessary getter in SearchCriteria

Download Browse

`public readonly` does the same thing with less boilerplate. Note that is likely that we will be able to directly pass `Option<StatusCriterion>` in the constructor and to make it work as expected with the latest version of Valinor. part of story #35821 Pull request new home page - Filter on Authors Change-Id: Ifa0ba8b59f84a57a953dd8ccd0b9776d06a4c0a9

+5 −13
Thomas Gerbet (tgerbet) 2024-01-11 11:40
Thomas Gerbet (tgerbet) 2024-01-11 14:40
cbbf11a0cb3d4f32b1441b5b16aa7e3f29251f12
9efd0b81950d0054453df60255ce6d5d37228fe6
git #tuleap/stable/cbbf11a0cb3d4f32b1441b5b16aa7e3f29251f12

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Criterion/SearchCriteria.php +1 −9 Go to diff View file
M plugins/pullrequest/include/PullRequest/Dao.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/RepositoryPullRequests/QueryToSearchCriteriaConverterTest.php +3 −3 Go to diff View file