Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: enable/disable mono-toolbar according to the current selection.

Download Browse

Part of story #38627: Choice of a new Rich Text Editor What has been fixed: When you press the up, down, right or left arrow keys to move from title to description, the toolbar is not enable/disable accordingly. Note: - The click listener must be kept to ensure that the toolbar is disabled when clicked outside the editor. - The plugin order has been changed, as the new `EnableOrDisableToolbarPlugin` must be initialized before `setupToolbar`. How to test: -- Click on the title -> The toolbar should be disabled -- Press the down arrow key -> The toolbar should be enable -- Press the up arrow key -> The toolbar should be disable -- Press the enter key -> The toolbar should be enable -- Press the backspace key -> The toolbar should be disable Change-Id: If403cbfd9f7daaf9a3c731f4f2b2d1639db83690

+263 −129
Clarisse Deschamps (cdeschamps) 2024-11-15 17:30
Clarisse Deschamps (cdeschamps) 2024-11-19 14:07
cc68bddc5b5712627587156acbd371d39fb0b40d
bb35538556b1132ab5963439c980e9d7dafb2265
git #tuleap/stable/cc68bddc5b5712627587156acbd371d39fb0b40d

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/prose-mirror-editor/src/use-editor.ts +1 −1 Go to diff View file
M plugins/artidoc/scripts/artidoc/package.json +1 −0 Go to diff View file
M plugins/artidoc/scripts/artidoc/pnpm-lock.yaml +9 −6 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/section/description/SectionDescriptionEditorProseMirror.vue +1 −1 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/enable-or-disable-toolbar.test.ts +59 −0 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/enable-or-disable-toolbar.ts +57 −0 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/jump-to-section-node.test.ts +30 −81 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/jump-to-section-node.ts +7 −24 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/setupMonoEditorPlugins.ts +28 −0 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/components/section/mono-editor/test-mono-editor-helper.ts +63 −0 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/helpers/toolbar-activator.test.ts +6 −14 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/helpers/toolbar-activator.ts +1 −2 Go to diff View file