Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: filtering and templating callback for all kinds of users

Download Browse

part of story #35822 Pull request new home page - Filter on Reviewer In this contribution, the filtering and templating callbacks of the Author selector entry are extracted from the Author filter context. It will allow us to reuse them for the Reviewer filter, since it is also a user selector, the display and filtering being strictly the same. -- no functional change expected Change-Id: I088f548e166be3e74392e59ae234fe5ef98594c5

+79 −8
Thomas Gorka (tgorka) 2024-03-05 14:13
Thomas Gorka (tgorka) 2024-03-06 14:40
cd314f63781a75ab0b03a8cb35de4c37d58c6e2c
c3e734e99ab1cafb905fd00358a8d92a0d8b681d
git #tuleap/stable/cd314f63781a75ab0b03a8cb35de4c37d58c6e2c

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Author/AuthorSelectorEntry.ts +5 −8 Go to diff View file
R plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Author/AuthorFilteringCallback.test.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Author/AuthorFilteringCallback.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Author/AuthorTemplatingCallback.test.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Author/AuthorTemplatingCallback.ts Go to diff View file
A plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Common/UserTypeGuard.test.ts +47 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequest-homepage/src/components/Filters/Common/UserTypeGuard.ts +27 −0 Go to diff View file