stable

Clone or download

Read-only

Tracker report comment filter takes into account private permission

This is part of story #19275 restrict who can see comments All comments user can see (private commments and non private comments) are now taken into account in the comment report criteria (in both UI and TQL). To ease the development, user and tracker objects are injected directly in the FromWhere object. To will be removed in a refactoring and both will be injected in the whole advanced query call stack. Change-Id: Idb8b7cbef0891cf66a099672d1e609fd7eb0f8ce

Modified Files

Name
M plugins/tracker/include/Tracker/Artifact/Changeset/Comment/PrivateComment/PermissionChecker.php +27 −15 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/CommentFromWhereBuilder.php +6 −66 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/CommentFromWhereBuilderFactory.php +52 −0 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/CommentWithPrivateCheckFromWhereBuilder.php +109 −0 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/CommentWithoutPrivateCheckFromWhereBuilder.php +81 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +45 −35 Go to diff View file
R plugins/tracker/tests/rest/Artifacts/PrivateCommentArtifactTest.php Go to diff View file
A plugins/tracker/tests/rest/PrivateComment/PrivateCommentReportQueryTest.php +90 −0 Go to diff View file
M plugins/tracker/tests/rest/TrackerBase.php +1 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/QueryBuilderVisitorTest.php +2 −2 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Report/Query/CommentFromWhereBuilderFactoryTest.php +81 −0 Go to diff View file