Part of story #18337 markdown replace text How to test: - rebuild rich-text-editor lib - rebuild tracker plugin No functional change expected in Rich text editors in the artifact view. Notes: Vanilla DOM API is replaced by lit-html because in the next commits, the rich text editors will have a lot of interactions and moving parts. Switching to/from Preview enables or disables buttons, it hides the textarea, it calls a remote API (with loading, errors, etc.) Seeing those conditions, Vanilla DOM becomes too cumbersome for that. lit-html will allow us to do all this much more easily. It also has a small size, it should not inflate our bundle size too much. The popover is now handled by a dedicated custom element. lit-html does not have a "mounted" lifecycle callback as Vue does. But now that IE11 is out of our support zone, we can finally leverage custom elements. Custom elements have a "connectedCallback" which is equivalent. As a note to the reviewer: I know that we should probably use Shadow DOM instead of querying the element's children, but it raises difficult challenges for now. As we don't have CSS Custom properties set up, we cannot style the button (or the popover content). Using Light DOM is a compromise until such time when we can properly style elements. I've made the choice to keep lit-html code separate from the rest of the code by using an intermediary "adapter". Code using it must pass plain old javascript "Presenters", that way if we decide (again) to change the lib, we should hopefully only have to rewrite the Renderer and the adapter. Change-Id: I58057408dce0d7ce804b361dbdebcd4aba4d0899

+1092 −688

Author

Joris MASSON (jmasson) 2021-03-17 12:26

Committer

Joris MASSON (jmasson) 2021-03-18 12:20

Hash cdf01bf40398027c05a8193def598fb31b47fcee

Parent 4c614f77b1a24797e775b2774a056f60cb4bed13

Reference git #tuleap/stable/cdf01bf40398027c05a8193def598fb31b47fcee