Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Reduce technical debt on BaselineArtifactRepositoryAdapter

Download Browse

Part of epic #12142 Baseline v1 Multiple levarage are used here to reduce technical debt: - spread complexity in multiple classes - which makes these classes testable (which improve test coverage) - wrap static function to enable depdendency injection (which improves test coverage) - remove one dependency (Tracker_Factory) Change-Id: If42ffec5f7438102160762642c1c96c7d754fa45

+1088 −111
Jean-Baptiste Mille (jibidus) 2019-04-01 17:44
Jean-Baptiste Mille (jibidus) 2019-04-03 15:01
cef20ada58db1572c0bcef945626d8c986667946
462b10e9dbdcc6d286b8363f3052ab878f4b87c8
git #tuleap/stable/cef20ada58db1572c0bcef945626d8c986667946

Modified Files

Side by side diff
Inline diff
Name
A include/Adapter/ArtifactLinkRepository.php +53 −0 Go to diff View file
M include/Adapter/BaselineArtifactRepositoryAdapter.php +18 −109 Go to diff View file
A include/Adapter/SemanticFieldRepository.php +59 −0 Go to diff View file
A include/Adapter/SemanticValueAdapter.php +105 −0 Go to diff View file
A phpunit/Adapter/ArtifactLinkRepositoryTest.php +121 −0 Go to diff View file
A phpunit/Adapter/BaselineArtifactRepositoryAdapterTest.php +199 −0 Go to diff View file
A phpunit/Adapter/SemanticValueAdapterFindDescriptionTest.php +112 −0 Go to diff View file
A phpunit/Adapter/SemanticValueAdapterFindInitialEffortTest.php +111 −0 Go to diff View file
A phpunit/Adapter/SemanticValueAdapterFindStatusTest.php +111 −0 Go to diff View file
A phpunit/Adapter/SemanticValueAdapterFindTitleTest.php +111 −0 Go to diff View file
A phpunit/Adapter/SemanticValueAdapterTest.php +77 −0 Go to diff View file
M phpunit/Factory/TrackerBuilder.php +11 −2 Go to diff View file