stable
Clone or download
Read-only
Summary ------- When user search for the same terms, we should not push for a new history: it will have same query and will screw up the navigation experience. Tests instructions ------------------ Note: You have to activate the feature beforehand: tuleap config-set feature_flag_search_for_documents_with_criteria 1 Open the developer console of your browser. Go to Advanced search page, and search for "Lorem ipsum". Click on submit button "Apply" multiple times. ➡️ You should not have NavigationDuplicated error in the console ➡️ The URL still change if you search for something else than previous query Implementation notes -------------------- Missing tests from previous contribution are added. plugins/document/scripts/document/helpers/local-vue.js has been converted to typescript, forcing every existing files depending on it to be changed. It could have been done in a dedicated contribution to not clutter the review, sorry about that. I can extract this if you think this is too much. The dependency SearchCriteriaPanel -> VueRouter has been removed. We already have dependency VueRouter -> SearchContainer (in plugins/document/scripts/document/router) therefore it seems better to contain dependency between only those two. Design proposal (as of today): * SearchContainer communicates with VueRouter (two ways) and perform the search * SearchCriteriaPanel displays search context (location, criteria) and takes input from the user for new searches * SearchResultTable displays the results SearchContainer template is now built with 3 components (header, criteria, results) to ease readability (instead of a mix of html and components). --- Part of story #24197: search for Documents with criteria Change-Id: Iaacaaedc179beeb0f6530f0a74c75709a5f8d805
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/document/package.json | +1 | −0 | Go to diff View file |
| M | plugins/document/pnpm-lock.yaml | +6 | −0 | Go to diff View file |
| A | plugins/document/scripts/document/components/AdvancedSearch/SearchContainer.test.ts | +94 | −0 | Go to diff View file |
| M | plugins/document/scripts/document/components/AdvancedSearch/SearchContainer.vue | +23 | −7 | Go to diff View file |
| A | plugins/document/scripts/document/components/AdvancedSearch/SearchCriteriaPanel.test.ts | +51 | −0 | Go to diff View file |
| M | plugins/document/scripts/document/components/AdvancedSearch/SearchCriteriaPanel.vue | +39 | −28 | Go to diff View file |
| A | plugins/document/scripts/document/components/AdvancedSearch/SearchHeader.vue | +31 | −0 | Go to diff View file |
| M | plugins/document/scripts/document/components/AdvancedSearch/SearchResultTable.vue | +1 | −3 | Go to diff View file |
| M | plugins/document/scripts/document/components/App.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ActionsButton/NewItemButton.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ActionsButton/NewItemVersionButton.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ActionsQuickLookButton/QuickLookButton.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ChildFolder.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Clipboard/ClipboardContentInformation.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DragNDrop/DragNDropHandler.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/CopyItem.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/CutItem.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/DownloadFolderAsZip.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalArchiveSizeWarning.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalMaxArchiveSizeThresholdExceeded.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownButton.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownCurrentFolder.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownDisplayedEmbedded.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownMenu.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownMenuTreeView.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/DropDownQuickLook.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/NewDocument.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/NewFolderSecondaryAction.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/PasteItem.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/UpdatePermissions.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DropDown/UpdateProperties.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Error/GlobalErrorModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Error/GoBackToRootButton.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Error/ItemPermissionError.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Error/ShowErrorDetails.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/FolderContent.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/FolderContentRow.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/FolderHeader.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/FolderHeaderAction.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ItemDisplay/ActionsHeader.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ItemDisplay/DisplayEmbedded.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ItemDisplay/DisplayEmbeddedContent.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ItemDisplay/EmbeddedFileEditionSwitcher.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ItemTitle/FolderCellTitle.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/LockInfo/DocumentTitleLockInfo.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/CustomMetadata/CustomMetadataComponentTypeRenderer.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/CustomMetadata/CustomMetadataListMultipleValue.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/DocumentMetadata/OtherInformationMetadataForCreate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/DocumentMetadata/OtherInformationMetadataForUpdate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/DocumentMetadata/StatusMetadataWithCustomBindingForDocumentCreate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/DocumentMetadata/StatusMetadataWithCustomBindingForDocumentUpdate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/FolderMetadata/FolderDefaultPropertiesForCreate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/FolderMetadata/FolderDefaultPropertiesForUpdate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/FolderMetadata/StatusMetadataWithCustomBindingForFolderCreate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/FolderMetadata/StatusMetadataWithCustomBindingForFolderUpdate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/ObsolescenceMetadata/ObsolescenceDateMetadataForCreate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/ObsolescenceMetadata/ObsolescenceDateMetadataForUpdate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/OwnerMetadata.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Metadata/TitleMetadata.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalDeleteItem/AdditionalCheckboxes/DeleteAssociatedWikiPageCheckbox.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalDeleteItem/ModalConfirmDeletion.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalNewItem/NewFolderModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalNewItem/NewItemModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalUpdateMetadata/UpdateFolderMetadataModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalUpdateMetadata/UpdateMetadataModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Permissions/PermissionsSelector.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Permissions/PermissionsUpdateFolderSubItems.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Permissions/PermissionsUpdateModal.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ProgressBar/UploadProgressBar.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/Property/ItemUpdateProperties.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/QuickLook/QuickLookDocumentAdditionalMetadataList.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/QuickLook/QuickLookDocumentMetadata.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/QuickLook/QuickLookDocumentPreview.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/QuickLook/QuickLookMetadataDate.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/RootFolder.test.js | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/SwitchToOldUI.test.js | +1 | −1 | Go to diff View file |
| R | plugins/document/scripts/document/helpers/local-vue.js | Go to diff View file | ||
| M | plugins/document/scripts/document/po/fr_FR.po | +3 | −3 | Go to diff View file |
| M | plugins/document/scripts/document/type.ts | +4 | −0 | Go to diff View file |