stable
Clone or download
Read-only
request #11432 Import labels-box instead of creating a library
We should aim to reduce interdependent files and instead rely on "import" to reveal explicitly dependencies. Previously, pull-request required "labels-box.js" to be loaded before it. This meant one more blocking HTTP request. Now, there is one less "entrypoint" javascript file. We should aim to have only one or two such files at initial load time. This also removes the dependency on a global variable published on window and makes it more explicit through "import". It also removes the need for a dedicated "labels" webpack configuration. How to test: - make post-checkout - Assigning labels to pull requests should run without error Change-Id: Ib1141dfd0523d7cdad8dd76d97670943b95028fe
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/include/pullrequestPlugin.class.php | +0 | −7 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/karma.config.js | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/package-lock.json | +6 | −0 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/package.json | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/src/app/labels/labels-controller.js | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/www/scripts/webpack.config.js | +15 | −9 | Go to diff View file |
| M | src/www/scripts/labels/labels-box.js | +0 | −1 | Go to diff View file |
| M | src/www/scripts/webpack.config.js | +0 | −27 | Go to diff View file |
| M | src/www/themes/common/tlp/src/js/fetch-wrapper.js | +12 | −12 | Go to diff View file |
| A | tools/utils/scripts/webpack-aliases.js | +52 | −0 | Go to diff View file |
| M | tools/utils/scripts/webpack-configurator.js | +3 | −2 | Go to diff View file |