stable
Clone or download
In order to not produce a too big review, the full conversion to BurningParrot will be done in multiple commits. To test, either uncomment the call to OneThreadController::getUrl() in ThreadsPresenterBuilder so that you can access the new view when browsing threads, or build the url by yourself. Like before (code has just been copied/arranged/tested), we should still be able to display: * text/plain messages * text/plain messages with (downloadable) attachments * text/html messages * text/html messages with (downloadable) attachments * text/html messages with inline images Things that will not be kept on purpose: * Display of sender's email address (to avoid exposing too much personal information) * Display of replies subject (OP's subject is good enough) * Automatic detection of quotations in text/plain message (lines starting with `>` being converted to <blockquote>). Let's see if users complain about the lack of this feature. Things to be done in next commits: * Display monospace font switch * Reply to a message * Remove commented call and use OneThreadController::getUrl() everywhere so that we can delete legacy code Part of request #18846: Switch ForumML to BurningParrot Change-Id: I1f6776b6da85d06a1de812db7d9bf6967d8b00b6
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/forumml/include/ForumML/CurrentListBreadcrumbCollectionBuilder.php | +3 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/ListInfoFromVariables.php | +98 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/ListInfoFromVariablesProvider.php | +129 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/AttachmentPresenter.php | +58 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/MessageInfo.php | +136 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/MessageInfoToMessagePresenterConvertor.php | +156 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/MessagePresenter.php | +87 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/OneThreadController.php | +125 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/OneThreadPresenter.php | +47 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/OneThreadPresenterBuilder.php | +248 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/Sender.php | +54 | −0 | Go to diff View file |
A | plugins/forumml/include/ForumML/OneThread/ThreadNotFoundException.php | +27 | −0 | Go to diff View file |
M | plugins/forumml/include/ForumML/Threads/ThreadsController.php | +25 | −93 | Go to diff View file |
M | plugins/forumml/include/ForumML/Threads/ThreadsPresenterBuilder.php | +3 | −0 | Go to diff View file |
R | plugins/forumml/include/ForumML/Threads/ThreadsDao.php | Go to diff View file | ||
M | plugins/forumml/include/forummlPlugin.php | +36 | −6 | Go to diff View file |
M | plugins/forumml/include/forumml_utils.php | +1 | −1 | Go to diff View file |
M | plugins/forumml/site-content/fr_FR/LC_MESSAGES/tuleap-forumml.po | +6 | −0 | Go to diff View file |
A | plugins/forumml/templates/one-thread.mustache | +39 | −0 | Go to diff View file |
A | plugins/forumml/tests/unit/ForumML/ListInfoFromVariablesProviderTest.php | +414 | −0 | Go to diff View file |
A | plugins/forumml/tests/unit/ForumML/OneThread/MessageInfoToMessagePresenterConvertorTest.php | +314 | −0 | Go to diff View file |
M | plugins/forumml/tests/unit/ForumML/Threads/ThreadsControllerTest.php | +21 | −13 | Go to diff View file |
A | plugins/forumml/themes/BurningParrot/css/_message.scss | +76 | −0 | Go to diff View file |
M | plugins/forumml/themes/BurningParrot/css/forumml.scss | +1 | −0 | Go to diff View file |
M | plugins/tracker/templates/form-element/reference/cross_reference.mustache | +1 | −7 | Go to diff View file |
A | src/templates/common/tlp_relative_date.mustache | +7 | −0 | Go to diff View file |