Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: DAO returns object instead of array

Download Browse

Part of story #26799 associate a Tuleap project and a GitLab group No functional change on the PATCH /gitlab_groups/:id REST route Notes: Having the DAO implement directly the Retrieve interface lets us drop the dependency on the factory and leads to less "primitive obsession". We don't return complicated arrays anymore. Change-Id: I7a8425417602dc48f21e86b2bcb3af5cad416eeb

+18 −111
Joris MASSON (jmasson) 2022-09-22 12:37
Joris MASSON (jmasson) 2022-09-22 14:54
d14dd959525f827c16830988210a64c2893cb713
411a947fc618e284e72e41c52e80e868e9c725b5
git #tuleap/stable/d14dd959525f827c16830988210a64c2893cb713

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Group/GitlabGroupDAO.php +8 −7 Go to diff View file
M plugins/gitlab/include/Group/GitlabGroupFactory.php +0 −14 Go to diff View file
D plugins/gitlab/include/Group/GitlabGroupLinkNotFoundException.php +0 −31 Go to diff View file
M plugins/gitlab/include/Group/RetrieveGroupLink.php +1 −1 Go to diff View file
M plugins/gitlab/include/REST/v1/GitlabGroupResource.php +8 −8 Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabGroupFactoryTest.php +1 −4 Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabRepositoryGroupLinkHandlerTest.php +0 −2 Go to diff View file
M plugins/gitlab/tests/unit/Group/GroupCreatorTest.php +0 −2 Go to diff View file
D plugins/gitlab/tests/unit/Test/Stubs/RetrieveGroupLinkStub.php +0 −42 Go to diff View file