How to test: - build the app and CSS - Add a Permission field on the Test Definition tracker. Set up a Test Definition artifact so that a user cannot read it. - Add the Test Definition to a campaign. - As that user, browse to the Details of the campaign (to see the list of tests) - Without this patch, an unhandled rejection error appears in the console and the spinner is always shown. With it, no error happens and only the tests the user can see will be shown. - Still as the same user, Edit the campaign - Without this patch, an infinite loop of requests happens. With it, only the tests the user can see will be shown. - When a user can't see ANY test of a campaign (or when you create a new campaign with no tests) then an empty state will be shown. - When a user can't see a definition and edits the campaign and add/remove tests, they don't remove the test definition they can't see. - REST errors when loading test executions will be shown (in feedback). - As anonymous, if you "cancel" the basic auth pop-ups, an error will be shown instead of infinite spinner. As the patch is already pretty big, some issues had to be left for later. Will be done later: - REST Errors in the Edit campaign modal are never handled (unhandled rejection in console) - Empty state in the Edit campaign modal - When someone who can see the test changes its status and when I learn about it through realtime, then there will be an unhandled rejection. The campaign progress bar will only be accurate on reload. - Removing $scope Change-Id: Ib3ae8b26af354bc85112684ad62e25e74734985c

+456 −136

Author

Joris MASSON (jmasson) 2018-08-07 16:49

Committer

Joris MASSON (jmasson) 2018-08-09 10:34

Hash d16500e950d21d6d61d1742baa5196aad812d8e3

Parent 61890bd671e847e22878c692b185512f999af230

Reference git #tuleap/stable/d16500e950d21d6d61d1742baa5196aad812d8e3