Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: covers ForbidWriters with REST tests

Download Browse

This changes involves some refactoring in existing tests setup: * Use directly \TestDataBuilder::ADMIN_USER_NAME, so that when we break the class hierarchy we don't need to change all the code. * Extract activation of docman plugin so that it is not executed multiple times (during the constructor, during the setup, …) No functional changes. Part of story #24980: forbid modifications of document properties by WRITERS Change-Id: I92265bcf07837b51281109dcce7ce289f910e54d

+549 −240
Nicolas Terray (nterray) 2022-03-10 14:14
Nicolas Terray (nterray) 2022-03-10 15:00
d2c0587613334df823328ab4b170253dd0ec7d57
75d809178837d9783b3a04fda4469db471b40834
git #tuleap/stable/d2c0587613334df823328ab4b170253dd0ec7d57

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/tests/rest/Docman/DocmanEmbeddedTest.php +24 −24 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanEmptyTest.php +34 −34 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanFilesTest.php +42 −42 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanFoldersTest.php +8 −8 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanItemsTest.php +1 −1 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanLinksTest.php +24 −24 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanProjectServiceTest.php +1 −1 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanWikiTest.php +16 −16 Go to diff View file
A plugins/docman/tests/rest/Docman/ForbidWritersTest.php +165 −0 Go to diff View file
M plugins/docman/tests/rest/DocmanDataBuilder.php +19 −15 Go to diff View file
A plugins/docman/tests/rest/DocmanForbidWritersDataBuilder.php +69 −0 Go to diff View file
M plugins/docman/tests/rest/DocmanWithMetadataActivatedDataBuilder.php +17 −23 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanEmbeddedDataBuild.php +4 −4 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanEmptyDataBuild.php +4 −4 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanFileDataBuild.php +4 −4 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanFolderDataBuild.php +4 −4 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanHardcodedMetadataExecutionHelper.php +2 −2 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanLinkDataBuild.php +4 −4 Go to diff View file
R plugins/docman/tests/rest/Helper/DocmanDataBuildCommon.php Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanSearchDataBuild.php +3 −2 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanTestExecutionHelper.php +5 −5 Go to diff View file
M plugins/docman/tests/rest/Helper/DocmanWikiDataBuild.php +4 −4 Go to diff View file
M plugins/docman/tests/rest/Metadata/CustomMetadataTest.php +8 −8 Go to diff View file
M plugins/docman/tests/rest/Metadata/HardcodedMetadataTest.php +7 −7 Go to diff View file
A plugins/docman/tests/rest/_fixtures/project-forbid-writers/project.xml +36 −0 Go to diff View file
A plugins/docman/tests/rest/_fixtures/project-forbid-writers/user_map.csv +3 −0 Go to diff View file
A plugins/docman/tests/rest/_fixtures/project-forbid-writers/users.xml +24 −0 Go to diff View file
M plugins/docman/tests/rest/init_test_data.php +17 −4 Go to diff View file