stable
Clone or download
We are changing the strategy here: instead of having to inject the ProjectBackgroundConfiguration on every controllers and every front scripts in project, we now do this only once in the Theme while displaying the header. This allows us to not repeat ourselves and miss a particular script. Now every pages in the project displays the background. Most of the times it will be only part of the background since we need to adjust styles, but since it is hidden behind a feature flag, it is considered acceptable. Styling will be adjusted as things progress in dedicated changesets. As before, if feature flag is off, then only project dashboards have the background. In order to test this, you need to have a project with a background: PUT /projects/:id/header_background { "identifier": "beach" } Part of story #16211 Set a header background image Change-Id: I359bd6047f3b05c088eeb40c71d2630bdbcae5be
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/Dashboard/Project/ProjectDashboardController.php | +1 | −14 | Go to diff View file |
| M | src/common/Project/Admin/Navigation/HeaderNavigationDisplayer.php | +0 | −17 | Go to diff View file |
| M | src/common/Project/Admin/ProjectDetails/ProjectDetailsController.php | +1 | −2 | Go to diff View file |
| M | src/common/Project/Admin/ProjectMembers/ProjectMembersController.php | +1 | −2 | Go to diff View file |
| M | src/common/Project/Admin/Routing/AdministrationLayoutHelper.php | +1 | −2 | Go to diff View file |
| M | src/common/Project/Home.php | +0 | −2 | Go to diff View file |
| M | src/common/Project/Label/IndexController.php | +1 | −2 | Go to diff View file |
| M | src/common/layout/BaseLayout.php | +26 | −0 | Go to diff View file |
| M | src/themes/BurningParrot/include/BurningParrotTheme.php | +2 | −0 | Go to diff View file |
| M | src/www/include/html.php | +0 | −14 | Go to diff View file |
| M | src/www/project/admin/editugroup.php | +1 | −2 | Go to diff View file |
| M | src/www/project/admin/permission_per_group.php | +1 | −2 | Go to diff View file |
| M | src/www/project/admin/project_admin_utils.php | +1 | −2 | Go to diff View file |
| M | src/www/project/admin/ugroup.php | +1 | −2 | Go to diff View file |
| M | src/www/themes/FlamingParrot/FlamingParrot_Theme.class.php | +5 | −0 | Go to diff View file |