Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #23391 Enhance banners configuration UX

Download Browse

Save button is now disabled if the user tries to activate the banner with an empty message. Before, the user was able to click the button but it didn't do anything. Moreover, having the message "No banner defined" even when the user didn't save the configuration was misleading. So the message has been removed. Change-Id: I5beeb0f3536423949bcf43162d6e376e36a435d6

+52 −58
Benjamin Dauton (bdauton_enalean) 2021-09-29 15:17
Benjamin Dauton (bdauton_enalean) 2021-09-30 09:22
d3554211063a0862ebe00ea95967e804033f6b4b
d29ec8a9f2ace83b42bbe0d7e9556345a91f237b
git #tuleap/stable/d3554211063a0862ebe00ea95967e804033f6b4b

Modified Files

Side by side diff
Inline diff
Name
M src/scripts/platform/banner/admin/po/fr_FR.po +3 −3 Go to diff View file
M src/scripts/platform/banner/admin/src/components/BannerPresenter.vue +11 −4 Go to diff View file
M src/scripts/platform/banner/admin/src/components/__snapshots__/BannerPresenter.test.ts.snap +3 −13 Go to diff View file
M src/scripts/project/admin/banner/po/fr_FR.po +8 −6 Go to diff View file
M src/scripts/project/admin/banner/src/components/BannerPresenter.vue +14 −7 Go to diff View file
M src/scripts/project/admin/banner/src/components/__snapshots__/BannerPresenter.test.ts.snap +13 −25 Go to diff View file