Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Direct access to embedded files should be logged in history

Download Browse

part of request #13807 No access is logged when user accesses a document on the new UI How to test: - load document tree with an embedded file inside => the access to document is NOT logged - load embedded file directly from the preview => the embedded file is displayed => the access to document is logged - access directly to the embedded file => the access to document is also logged Open the API explorer - docman_items/id/docman_items => content is no longer avilable for embedded files - docman_items/id/parent => content is no longer available for embedded files Please note that error handling and spinner are not the best at the moment (like on master), I will improve them in a dedicated commit Change-Id: Id7de15ca2bdb4c160f72cc4fbcdd74f2b07ae6ac

+338 −33
Marie Ange Garnier (marieange) 2019-10-02 15:37
Marie Ange Garnier (marieange) 2019-10-03 12:39
d4497429351789d735a5fc63eda8d584695a542c
f8b8cccc489ac7f35db8ea41b07c285f0613be45
git #tuleap/stable/d4497429351789d735a5fc63eda8d584695a542c

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/Docman_File.class.php +3 −0 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemsResource.php +7 −7 Go to diff View file
A plugins/docman/include/REST/v1/EmbeddedFiles/EmbeddedFilePropertiesFullRepresentation.php +48 −0 Go to diff View file
R plugins/docman/include/REST/v1/EmbeddedFiles/EmbeddedFilePropertiesRepresentation.php Go to diff View file
A plugins/docman/include/REST/v1/EmbeddedFiles/IEmbeddedFilePropertiesRepresentation.php +27 −0 Go to diff View file
M plugins/docman/include/REST/v1/ItemRepresentation.php +3 −3 Go to diff View file
M plugins/docman/include/REST/v1/ItemRepresentationBuilder.php +2 −2 Go to diff View file
M plugins/docman/include/REST/v1/ItemRepresentationCollectionBuilder.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/ItemRepresentationVisitor.php +36 −4 Go to diff View file
M plugins/docman/phpunit/REST/v1/EmbeddedFiles/EmbeddedFileVersionCreatorTest.php +16 −11 Go to diff View file
M plugins/docman/phpunit/REST/v1/ItemRepresentationCollectionBuilderTest.php +7 −1 Go to diff View file
A plugins/docman/phpunit/REST/v1/ItemRepresentationVisitorTest.php +187 −0 Go to diff View file
M plugins/docman/tests/rest/Docman/DocmanItemsTest.php +1 −4 Go to diff View file