stable
Clone or download
Read-only
part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: when there is a Done or a Closed value, the Artifact is closed with a comment with a reference pointing back to the GitLab commit. Notes: By extracting an interface for this reference, we allow Git plugin to give a reference to a Git commit in the event to trigger the closure of the artifact. We cannot give the entire comment because Git does not know about Tracker Artifacts (parsing of references is done in Tracker plugin). This way, Git plugin does not know about Tracker Artifacts and Tracker plugin does not know about Git commits, but they can work together. Change-Id: Ic609adb0a3292bd91bbd75083c07223ecec551e2
Modified Files
| Name | ||||
|---|---|---|---|---|
| A | plugins/gitlab/include/Repository/Webhook/PostPush/GitlabCommitReferenceString.php | +50 | −0 | Go to diff View file |
| D | plugins/gitlab/include/Repository/Webhook/PostPush/PostPushArtifactComment.php | +0 | −68 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandler.php | +8 | −5 | Go to diff View file |
| A | plugins/gitlab/tests/unit/Repository/Webhook/PostPush/GitlabCommitReferenceStringTest.php | +71 | −0 | Go to diff View file |
| D | plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushArtifactCommentTest.php | +0 | −135 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Closure/ArtifactClosingCommentInCommonMarkFormat.php | +31 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Closure/ArtifactCloserTest.php | +16 | −5 | Go to diff View file |
| A | plugins/tracker/tests/unit/Artifact/Closure/ArtifactClosingCommentInCommonMarkFormatTest.php | +81 | −0 | Go to diff View file |
| A | src/common/Reference/ReferenceString.php | +32 | −0 | Go to diff View file |
| R | plugins/tracker/tests/unit/Stub/ArtifactClosingCommentInCommonMarkFormatStub.php | Go to diff View file |