part of story #29240 reply to pull request comment Introduced by git #tuleap/stable/10a71734c6aeeba92f5561f78c9193f1cf7f87cf The size of avatars has been changed, but the margin left of the form has been left unmodified, resulting to the misalignment of the form and the comments thread Moreover, there was a deprecation notice regarding a computation in the styles. It should be fixed now. ``` Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div($tlp-avatar-width, 2) or calc($tlp-avatar-width / 2) More info and automated migrator: https://sass-lang.com/d/slash-div ../../themes/includes/_tuleap-pullrequest-comment.scss 189:24 @use ../../themes/pull-requests.scss 31:1 root stylesheet ``` How to test: - Add a comment - Add a reply - Toggle the reply form --> The form is aligned with the thread Change-Id: Ife7829f6b5e466170aa10c239c70c9e1426d3444

+8 −5

Author

Thomas Gorka (tgorka) 2022-11-09 10:02

Committer

Thomas Gorka (tgorka) 2022-11-09 10:02

Hash d5e434790ac6501e93c1d170bddd31a40e009352

Parent c96caa76f57106a69a505a0b04b7821e35d2c1b4

Reference git #tuleap/stable/d5e434790ac6501e93c1d170bddd31a40e009352