Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class when the

Download Browse

PR status change Use the dedicated class instead a god factory to retrieve a pull request by its id. Remove the remaining usage of the factory. No functionnal change expected, notification when the status of the pull request changes is still sent Part of request #35473 Stop relying on the god PullRequest/Factory class to retrieve pull request Change-Id: I43bb2df9ae5e8268ed7000256f77a6216f39ba84

+135 −266
Clarck Robinson (robinsoc) 2023-12-06 16:41
Clarck Robinson (robinsoc) 2023-12-13 11:20
d66161d370a8cafce431b6c05e5ba7bc9ef2e235
3a671a66b26044345941e86206e9c0be8e6aeb15
git #tuleap/stable/d66161d370a8cafce431b6c05e5ba7bc9ef2e235

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Factory.php +0 −15 Go to diff View file
M plugins/pullrequest/include/PullRequest/Notification/PullRequestNotificationSupport.php +2 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/StateStatus/PullRequestAbandonedNotificationToProcessBuilder.php +29 −61 Go to diff View file
M plugins/pullrequest/include/PullRequest/StateStatus/PullRequestMergedNotificationToProcessBuilder.php +29 −61 Go to diff View file
M plugins/pullrequest/tests/unit/StateStatus/PullRequestAbandonedNotificationToProcessBuilderTest.php +37 −61 Go to diff View file
M plugins/pullrequest/tests/unit/StateStatus/PullRequestMergedNotificationToProcessBuilderTest.php +38 −63 Go to diff View file