Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Optional object instead of boolean verify

Download Browse

part of request #39352 Program add to top backlog post-action should ignore Teams No functional change. Listing the workflow post-actions for a given transition should still only require that the Program project has the Program service enabled. Why? The object can encapsulate data, such as the project ID, while a boolean cannot store more data than itself. We can later trade that object for a ProgramIdentifier without more parameters: it represents the fact that the verification has been done, just like a real-world certificate or diploma does. Change-Id: I7fefcbed0ab1c522cd4a2ae29b8f6833fa239a5b

+106 −246
Joris MASSON (jmasson) 2024-09-16 12:00
Joris MASSON (jmasson) 2024-09-16 15:12
d6c86bd1a0e5a07ff8d35eec518d81b2b3c3ee73
da8f9d600c9440fee4f5e5ec97948bdbc7da260e
git #tuleap/stable/d6c86bd1a0e5a07ff8d35eec518d81b2b3c3ee73

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactory.php +20 −20 Go to diff View file
R plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ProgramServiceIsEnabledVerifier.php Go to diff View file
D plugins/program_management/include/Domain/Program/Backlog/TopBacklog/ProgramIdentifierForTopBacklogAction.php +0 −51 Go to diff View file
M plugins/program_management/include/Domain/Program/ProgramIdentifier.php +1 −3 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/TopBacklog/VerifyProgramServiceIsEnabled.php Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +3 −4 Go to diff View file
D plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/ProgramForTopBacklogActionVerifierTest.php +0 −65 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactoryTest.php +17 −8 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Workspace/ProgramServiceIsEnabledCertifierTest.php +65 −0 Go to diff View file
D plugins/program_management/tests/unit/Domain/Program/Backlog/TopBacklog/ProgramIdentifierForTopBacklogActionTest.php +0 −49 Go to diff View file
D plugins/program_management/tests/unit/Tests/Stub/Workspace/VerifyProgramServiceIsEnabledStub.php +0 −46 Go to diff View file